jimingham wrote: That sounds entirely appropriate.
Jim > On Sep 30, 2024, at 1:49 PM, Walter Erquinigo ***@***.***> wrote: > > > @walter-erquinigo commented on this pull request. > > In lldb/source/Core/Module.cpp > <https://github.com/llvm/llvm-project/pull/110543#discussion_r1781718532>: > > > @@ -797,6 +797,10 @@ void Module::LookupInfo::Prune(SymbolContextList > > &sc_list, > while (i < sc_list.GetSize()) { > if (!sc_list.GetContextAtIndex(i, sc)) > break; > + if (!lldb_private::Language::LanguageIsCFamily(sc.GetLanguage())) { > What you say makes sense. > @jimingham <https://github.com/jimingham> , what about me moving the > implementation of this second part of the Prune method (line 790 onwards) to > Language plugins? I could then create the method > SymbolLookupPruneHook(SymbolContextList &sc_list, size_t start_idx, > Module::LookupInfo &lookup_info, Module &module) > > That would be very convenient because I could implement this in my own > language plugin for further refinements. > > What do you think? > > — > Reply to this email directly, view it on GitHub > <https://github.com/llvm/llvm-project/pull/110543#discussion_r1781718532>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADUPVW4FUUNGIJVLEB23B6LZZG2O5AVCNFSM6AAAAABPD35ZI2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMZYGUZTONRVGU>. > You are receiving this because you were mentioned. > https://github.com/llvm/llvm-project/pull/110543 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
