Author: Greg Clayton Date: 2024-09-30T09:04:09-07:00 New Revision: b086f7591ce8d4f810a472554d38b4437dff6919
URL: https://github.com/llvm/llvm-project/commit/b086f7591ce8d4f810a472554d38b4437dff6919 DIFF: https://github.com/llvm/llvm-project/commit/b086f7591ce8d4f810a472554d38b4437dff6919.diff LOG: Fix an integer trunctation issues for the DW_AT_frame_base DWARF location expression (#110388) This patch allows offsets to the DW_AT_frame_base to exceed 4GB. Prior to this, for any .debug_info.dwo offset that exceeded 4GB, we would truncate the offset to the DW_AT_frame_base expression bytes to be 32 bit only. Changing the offset to 64 bits restores correct functionality. No test for this as we don't want to create a .dwp file that has a .debug_info.dwo size that is over 4GB. Added: Modified: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp index 77ef59d605c9c4..66d0bc4b90cb52 100644 --- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp +++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp @@ -229,9 +229,9 @@ bool DWARFDebugInfoEntry::GetDIENamesAndRanges( case DW_AT_frame_base: if (frame_base) { if (form_value.BlockData()) { - uint32_t block_offset = + uint64_t block_offset = form_value.BlockData() - data.GetDataStart(); - uint32_t block_length = form_value.Unsigned(); + uint64_t block_length = form_value.Unsigned(); *frame_base = DWARFExpressionList(module, DWARFExpression(DataExtractor( _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
