I am fine with this. It is in MIPS only code so it shouldn't affect anything else.
> On Aug 2, 2016, at 8:49 AM, Hans Wennborg <h...@chromium.org> wrote: > > While this all seems very MIPS-specific, so probably fine to merge if > you want to, it does look more like new development than just bug > fixing. > > I'm OK with merging this if Clayton approves, though. > > Thanks, > Hans > > On Tue, Aug 2, 2016 at 12:49 AM, Nitesh Jain <nitesh.j...@imgtec.com> wrote: >> Hi Hans, >> >> Could you please merge this to the LLDB 3.9 release branch ? >> >> Thanks & regards, >> Nitesh Jain >> >> -----Original Message----- >> From: Nitesh Jain >> Sent: 02 August 2016 12:56 >> To: Nitesh Jain >> Subject: Re: [Diffusion] rL277426: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI >> instructions emulation . Fix emulation… >> >> nitesh.jain committed rL277426: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI >> instructions emulation . Fix emulation…. >> >> [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix >> emulation for (D)ADDIU, SD/SW and LW/LD instructions >> >> Reviewers: clayborg, jaydeep, bhushan >> >> Subscribers: mohit.bhakkad, slthakur, sdardis, lldb-commits >> >> Differential Revision: https://reviews.llvm.org/D22851 >> >> >> Files: >> /lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp >> /lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h >> /lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp >> /lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h >> >> Users: >> nitesh.jain (Author) >> >> https://reviews.llvm.org/rL277426 >> >> >> _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
