tberghammer added inline comments.

================
Comment at: source/Core/ArchSpec.cpp:1017
@@ +1016,3 @@
+    // considered to be compatible. This is required as a workaround for 
shared libraries compiled
+    // for Android without the NOTE section indicating that they are using the 
Android ABI.
+    if (lhs == llvm::Triple::Android && (rhs == llvm::Triple::EABI || rhs == 
llvm::Triple::EABIHF))
----------------
rengolin wrote:
> Are you sure AndroidEabi and EabiHF are compatible? Android is always 
> soft-float, is it not?
They are not always compatible but I don't see any way to detect it in the 
current system and it is possible to have code compiled with AndroidEabi and 
AndroidEabiHF inside the same application if all API crossing the ABI 
boundaries are annotated with attribute((pcs("aapcs"))).

The android platform libraries are soft float with all API with floating point 
argument is marked with attribute((pcs("aapcs"))) so user libraries can be hard 
float (not sure how well it works)


http://reviews.llvm.org/D19480



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to