On Fri, Feb 19, 2016 at 12:33 PM, Jim Ingham <jing...@apple.com> wrote:
> Please don't make this sort of change.  With the code as originally written, 
> I can set a breakpoint on the returns "true" or "false" case separately, and 
> stop there if I am doing that experiment, whereas your change makes that 
> impossible.  Neither one is particularly harder to read than the other, but 
> your version is significantly harder to debug.
>
> Jim

I this particular case it'w much easier to debug at point of usage.
Actually multiple comparisons could be replaced with strchr().

Eugene.
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to