Author: spyffe Date: Fri Feb 12 12:42:00 2016 New Revision: 260699 URL: http://llvm.org/viewvc/llvm-project?rev=260699&view=rev Log: Renamed TestRdar12991846 to the more descriptive TestUnicodeLiterals.
Test cases should not be named after PR or Radar numbers. It's fine to annotate them with these numbers in comments, however. Added: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unicode-literals/ - copied from r260638, lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/rdar12991846/ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unicode-literals/TestUnicodeLiterals.py - copied, changed from r260638, lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/rdar12991846/TestRdar12991846.py Removed: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/rdar12991846/ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unicode-literals/TestRdar12991846.py Removed: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unicode-literals/TestRdar12991846.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/rdar12991846/TestRdar12991846.py?rev=260638&view=auto ============================================================================== --- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unicode-literals/TestRdar12991846.py (original) +++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unicode-literals/TestRdar12991846.py (removed) @@ -1,86 +0,0 @@ -# coding=utf8 -""" -Test that the expression parser returns proper Unicode strings. -""" - -from __future__ import print_function - - - -import unittest2 -import os, time -import lldb -from lldbsuite.test.decorators import * -from lldbsuite.test.lldbtest import * -from lldbsuite.test import lldbutil - -# this test case fails because of rdar://12991846 -# the expression parser does not deal correctly with Unicode expressions -# e.g. -#(lldb) expr L"Hello" -#(const wchar_t [6]) $0 = { -# [0] = \0\0\0\0 -# [1] = \0\0\0\0 -# [2] = \0\0\0\0 -# [3] = \0\0\0\0 -# [4] = H\0\0\0 -# [5] = e\0\0\0 -#} - -class Rdar12991846TestCase(TestBase): - - mydir = TestBase.compute_mydir(__file__) - - @unittest2.expectedFailure("rdar://18684408") - @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows") - def test_expr1(self): - """Test that the expression parser returns proper Unicode strings.""" - self.build() - self.rdar12991846(expr=1) - - @unittest2.expectedFailure("rdar://18684408") - @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows") - def test_expr2(self): - """Test that the expression parser returns proper Unicode strings.""" - self.build() - self.rdar12991846(expr=2) - - @unittest2.expectedFailure("rdar://18684408") - @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows") - def test_expr3(self): - """Test that the expression parser returns proper Unicode strings.""" - self.build() - self.rdar12991846(expr=3) - - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - # Find the line number to break for main.cpp. - self.source = 'main.cpp' - self.line = line_number(self.source, '// Set break point at this line.') - - def rdar12991846(self, expr=None): - """Test that the expression parser returns proper Unicode strings.""" - if self.getArchitecture() in ['i386']: - self.skipTest("Skipping because this test is known to crash on i386") - - exe = os.path.join(os.getcwd(), "a.out") - - # Create a target by the debugger. - target = self.dbg.CreateTarget(exe) - self.assertTrue(target, VALID_TARGET) - - # Break on the struct declration statement in main.cpp. - lldbutil.run_break_set_by_file_and_line (self, "main.cpp", self.line) - - # Now launch the process, and do not stop at entry point. - process = target.LaunchSimple (None, None, self.get_process_working_directory()) - - if not process: - self.fail("SBTarget.Launch() failed") - - if expr == 1: self.expect('expression L"hello"', substrs = ['hello']) - - if expr == 2: self.expect('expression u"hello"', substrs = ['hello']) - - if expr == 3: self.expect('expression U"hello"', substrs = ['hello']) Copied: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unicode-literals/TestUnicodeLiterals.py (from r260638, lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/rdar12991846/TestRdar12991846.py) URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unicode-literals/TestUnicodeLiterals.py?p2=lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unicode-literals/TestUnicodeLiterals.py&p1=lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/rdar12991846/TestRdar12991846.py&r1=260638&r2=260699&rev=260699&view=diff ============================================================================== --- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/rdar12991846/TestRdar12991846.py (original) +++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unicode-literals/TestUnicodeLiterals.py Fri Feb 12 12:42:00 2016 @@ -27,7 +27,7 @@ from lldbsuite.test import lldbutil # [5] = e\0\0\0 #} -class Rdar12991846TestCase(TestBase): +class UnicodeLiteralsTestCase(TestBase): mydir = TestBase.compute_mydir(__file__) _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits