[Lldb-commits] [lldb] r259443 - We try to avoid static objects. These are on the error path for unsupported features

[Jim Ingham via lldb-commits]

Author: jingham
Date: Mon Feb  1 18:21:39 2016
New Revision: 259443

URL: http://llvm.org/viewvc/llvm-project?rev=259443&view=rev
Log:
We try to avoid static objects.  These are on the error path for unsupported 
features
in the socket, so just returning freshly constructed objects is fine.

Modified:
    lldb/trunk/source/Host/common/UDPSocket.cpp

Modified: lldb/trunk/source/Host/common/UDPSocket.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/UDPSocket.cpp?rev=259443&r1=259442&r2=259443&view=diff
==============================================================================
--- lldb/trunk/source/Host/common/UDPSocket.cpp (original)
+++ lldb/trunk/source/Host/common/UDPSocket.cpp Mon Feb  1 18:21:39 2016
@@ -27,7 +27,7 @@ namespace {
 const int kDomain = AF_INET;
 const int kType   = SOCK_DGRAM;
 
-const Error kNotSupported("Not supported");
+static const char *g_not_supported_error = "Not supported";
 
 }
 
@@ -55,19 +55,19 @@ UDPSocket::Send(const void *buf, const s
 Error
 UDPSocket::Connect(llvm::StringRef name)
 {
-    return kNotSupported;
+    return Error("%s", g_not_supported_error);
 }
 
 Error
 UDPSocket::Listen(llvm::StringRef name, int backlog)
 {
-    return kNotSupported;
+    return Error("%s", g_not_supported_error);
 }
 
 Error
 UDPSocket::Accept(llvm::StringRef name, bool child_processes_inherit, Socket 
*&socket)
 {
-    return kNotSupported;
+    return Error("%s", g_not_supported_error);
 }
 
 Error


_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits