spyffe added a comment.

I'm a little concerned that LanguageRuntime::GetOverrideExprOptions() appears 
to generate a new set of options from whole cloth rather than using the 
existing set as a starting point.

Specifically, since your use case is wanting to override the calling 
convention, I think it's heavy handed to override all the options.  I could 
conceive of new expression parser features changing some other flags in the 
future, and it'd be unfortunate if we had to duplicate those features in the 
ActionScript code just because the options are being overridden.

Could we model this as OverrideExprOptions(clang::TargetOptions &) instead and 
modify the options in place?  That way customizations could stack.


http://reviews.llvm.org/D15527



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to