clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good, just check me inline comment and make changes if you think you need
to.
================
Comment at: source/Commands/CommandObjectPlatform.cpp:414-419
@@ -413,1 +413,8 @@
+
+
platform_sp->ConnectToWaitingProcesses(m_interpreter.GetDebugger(), error);
+ if (error.Fail())
+ {
+ result.AppendError (error.AsCString());
+ result.SetStatus (eReturnStatusFailed);
+ }
}
----------------
So should the default Platform::ConnectToWaitingProcesses() return an error?
Seems like this calls should be documented to say "only return an error if you
actually tried to connect to a waiting process and that failed, and if there
are no processes, return an error that has been cleared". We don't want
"platform connect" to fail due to not being able to connect to a waiting
process do we?
http://reviews.llvm.org/D14952
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
