labath added a subscriber: labath. labath requested changes to this revision. labath added a reviewer: labath. labath added a comment. This revision now requires changes to proceed.
I don't approve of automagic dependencies. With this patch it won't be possible to force curses usage. Even if you specify -DLLDB_DISABLE_CURSES=0, it will still build (sure, it will show a message about not being found, but who reads those...) even if it can't find the library, leading to surprises further down the line. I recommend doing one of the following: - Leave things as they are. It is already possible to disable curses with the right switch - Tweak the error message to inform the user of possible actions (but leave it a fatal error). E.g., "Curses library not found. Please install the library or reconfigure with LLDB_DISABLE_CURSES=0." - set LLDB_DISABLE_CURSES=1 on netbsd only. (less magic, it only depends on the platform, not it's runtime properties, which can change randomly) Repository: rL LLVM http://reviews.llvm.org/D14740 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
