Re: [Lldb-commits] [PATCH] D14177: Better handle the arguments common to all MI commands.

[Hafiz Abid Qadeer via lldb-commits]

abidh marked an inline comment as done.

================
Comment at: tools/lldb-mi/MICmdBase.h:68
@@ -67,2 +67,3 @@
     virtual MIuint GetGUID();
+    void AddCommonArgs();
 
----------------
Changed name. But it cant be protected as it is called from the outside.

================
Comment at: tools/lldb-mi/MICmdInvoker.cpp:192
@@ -191,3 +191,3 @@
 
-    if (bOk && !vCmd.ParseArgs())
+    if (bOk)
     {
----------------
Done.


http://reviews.llvm.org/D14177



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits