tfiala added a comment.

Yep, that modified patch worked for both:

  cmake -DLLDB_DISABLE_LIBEDIT=1

where libedit is disabled from the build, and for the normal case where libedit 
is available.  In both cases it did the right thing - simple readline support 
with libedit and your change (minor tweaks by me solely on comments and 
conditional libedit), and for the no-libedit case (where it behaves as before, 
including the no-crash part :-) ).

If you can update the patch with that, it looks good to me.


Repository:
  rL LLVM

http://reviews.llvm.org/D13268



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to