Author: zturner Date: Wed Sep 2 11:47:37 2015 New Revision: 246671 URL: http://llvm.org/viewvc/llvm-project?rev=246671&view=rev Log: Change Windows XFAIL comment for TestCompletion.py
Instead of fixing these tests by finding a pexpect replacement, this set of tests can be fixed by re-writing the test to not use pexpect. llvm.org/pr24679 Modified: lldb/trunk/test/functionalities/completion/TestCompletion.py Modified: lldb/trunk/test/functionalities/completion/TestCompletion.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/completion/TestCompletion.py?rev=246671&r1=246670&r2=246671&view=diff ============================================================================== --- lldb/trunk/test/functionalities/completion/TestCompletion.py (original) +++ lldb/trunk/test/functionalities/completion/TestCompletion.py Wed Sep 2 11:47:37 2015 @@ -20,153 +20,153 @@ class CommandLineCompletionTestCase(Test except: pass - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_at(self): """Test that 'at' completes to 'attach '.""" self.complete_from_to('at', 'attach ') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_de(self): """Test that 'de' completes to 'detach '.""" self.complete_from_to('de', 'detach ') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_process_attach_dash_dash_con(self): """Test that 'process attach --con' completes to 'process attach --continue '.""" self.complete_from_to('process attach --con', 'process attach --continue ') # <rdar://problem/11052829> - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_infinite_loop_while_completing(self): """Test that 'process print hello\' completes to itself and does not infinite loop.""" self.complete_from_to('process print hello\\', 'process print hello\\', turn_off_re_match=True) - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_watchpoint_co(self): """Test that 'watchpoint co' completes to 'watchpoint command '.""" self.complete_from_to('watchpoint co', 'watchpoint command ') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_watchpoint_command_space(self): """Test that 'watchpoint command ' completes to ['Available completions:', 'add', 'delete', 'list'].""" self.complete_from_to('watchpoint command ', ['Available completions:', 'add', 'delete', 'list']) - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_watchpoint_command_a(self): """Test that 'watchpoint command a' completes to 'watchpoint command add '.""" self.complete_from_to('watchpoint command a', 'watchpoint command add ') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_watchpoint_set_variable_dash_w(self): """Test that 'watchpoint set variable -w' completes to 'watchpoint set variable -w '.""" self.complete_from_to('watchpoint set variable -w', 'watchpoint set variable -w ') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_watchpoint_set_variable_dash_w_space(self): """Test that 'watchpoint set variable -w ' completes to ['Available completions:', 'read', 'write', 'read_write'].""" self.complete_from_to('watchpoint set variable -w ', ['Available completions:', 'read', 'write', 'read_write']) - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_watchpoint_set_ex(self): """Test that 'watchpoint set ex' completes to 'watchpoint set expression '.""" self.complete_from_to('watchpoint set ex', 'watchpoint set expression ') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_watchpoint_set_var(self): """Test that 'watchpoint set var' completes to 'watchpoint set variable '.""" self.complete_from_to('watchpoint set var', 'watchpoint set variable ') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_watchpoint_set_variable_dash_w_read_underbar(self): """Test that 'watchpoint set variable -w read_' completes to 'watchpoint set variable -w read_write'.""" self.complete_from_to('watchpoint set variable -w read_', 'watchpoint set variable -w read_write') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_help_fi(self): """Test that 'help fi' completes to ['Available completions:', 'file', 'finish'].""" self.complete_from_to('help fi', ['Available completions:', 'file', 'finish']) - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_help_watchpoint_s(self): """Test that 'help watchpoint s' completes to 'help watchpoint set '.""" self.complete_from_to('help watchpoint s', 'help watchpoint set ') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_settings_append_target_er(self): """Test that 'settings append target.er' completes to 'settings append target.error-path'.""" self.complete_from_to('settings append target.er', 'settings append target.error-path') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_settings_insert_after_target_en(self): """Test that 'settings insert-after target.env' completes to 'settings insert-after target.env-vars'.""" self.complete_from_to('settings insert-after target.env', 'settings insert-after target.env-vars') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_settings_insert_before_target_en(self): """Test that 'settings insert-before target.env' completes to 'settings insert-before target.env-vars'.""" self.complete_from_to('settings insert-before target.env', 'settings insert-before target.env-vars') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_settings_replace_target_ru(self): """Test that 'settings replace target.ru' completes to 'settings replace target.run-args'.""" self.complete_from_to('settings replace target.ru', 'settings replace target.run-args') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_settings_s(self): """Test that 'settings s' completes to ['Available completions:', 'set', 'show'].""" self.complete_from_to('settings s', ['Available completions:', 'set', 'show']) - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_settings_set_th(self): """Test that 'settings set th' completes to 'settings set thread-format'.""" self.complete_from_to('settings set th', 'settings set thread-format') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_settings_s_dash(self): """Test that 'settings set -' completes to 'settings set -g'.""" self.complete_from_to('settings set -', 'settings set -g') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_settings_clear_th(self): """Test that 'settings clear th' completes to 'settings clear thread-format'.""" self.complete_from_to('settings clear th', 'settings clear thread-format') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_settings_set_ta(self): """Test that 'settings set ta' completes to 'settings set target.'.""" self.complete_from_to('settings set ta', 'settings set target.') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_settings_set_target_exec(self): """Test that 'settings set target.exec' completes to 'settings set target.exec-search-paths '.""" self.complete_from_to('settings set target.exec', 'settings set target.exec-search-paths') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_settings_set_target_pr(self): """Test that 'settings set target.pr' completes to ['Available completions:', @@ -176,19 +176,19 @@ class CommandLineCompletionTestCase(Test 'target.prefer-dynamic-value', 'target.process.']) - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_settings_set_target_process(self): """Test that 'settings set target.process' completes to 'settings set target.process.'.""" self.complete_from_to('settings set target.process', 'settings set target.process.') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_settings_set_target_process_dot(self): """Test that 'settings set target.process.t' completes to 'settings set target.process.thread.'.""" self.complete_from_to('settings set target.process.t', 'settings set target.process.thread.') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_settings_set_target_process_thread_dot(self): """Test that 'settings set target.process.thread.' completes to ['Available completions:', @@ -198,7 +198,7 @@ class CommandLineCompletionTestCase(Test 'target.process.thread.step-avoid-regexp', 'target.process.thread.trace-thread']) - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_target_space(self): """Test that 'target ' completes to ['Available completions:', 'create', 'delete', 'list', @@ -207,19 +207,18 @@ class CommandLineCompletionTestCase(Test ['Available completions:', 'create', 'delete', 'list', 'modules', 'select', 'stop-hook', 'variable']) - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_target_create_dash_co(self): """Test that 'target create --co' completes to 'target variable --core '.""" self.complete_from_to('target create --co', 'target create --core ') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @skipIfFreeBSD # timing out on the FreeBSD buildbot def test_target_va(self): """Test that 'target va' completes to 'target variable '.""" self.complete_from_to('target va', 'target variable ') - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") @skipUnlessDarwin @dsym_test def test_symbol_name_dsym(self): @@ -229,7 +228,7 @@ class CommandLineCompletionTestCase(Test 'breakpoint set -n Foo::Bar(int,\\ int)', turn_off_re_match=True) - @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect replacement for windows") + @expectedFailureHostWindows("llvm.org/pr24679") @dwarf_test def test_symbol_name_dwarf(self): self.buildDwarf() _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits