What I'm getting at is that, assuming my understanding is correct, something like an adapter could be created that each plugin could implement. Say you've got a DebugInfoAdapter interface with DebugInfoDwarf, etc implementations. Then ClangASTContext could just use this.
On Thu, Aug 27, 2015 at 2:18 PM <d...@burble.org> wrote: > On Thu, Aug 27, 2015 at 09:12:06PM +0000, Zachary Turner wrote: > > If I'm following this discussion correctly, Greg are you saying that > > ClangASTContext could be renamed to DwarfASTContext? And that for other > > types of Debug info we could have PascalASTContext and PdbASTContext? > > > > If that's the case, then it seems there is a lot of code inside of > > ClangASTContext (aka DwarfASTContext) which is not specific to DWARF, and > > there's no reason that other ASTContext classes shouldn't be able to > reuse > > it. > > Renaming and reusing the ClangASTContext code would help but it's not > enough - the DWARF code belongs in the DWARF plugin. Plugins should be > just that - pluggable! :) >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
