Re: [Lldb-commits] [PATCH] D12239: Fix buffer overflow for fixed_form_sizes

[Tamas Berghammer via lldb-commits]

tberghammer added inline comments.

================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h:165
@@ -164,3 +164,3 @@
                     const DWARFCompileUnit* cu,
-                    const uint8_t *fixed_form_sizes,
+                    DWARFFormValue::FixedFormSizes fixed_form_sizes,
                     DWARFDebugInfoEntry::Attributes& attrs,
----------------
Note: Get attributes have to make a copy of fixed_form_sizes because it query a 
new fixed_form_sizes object if an empty object was passed in.


http://reviews.llvm.org/D12239



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits