tberghammer added inline comments.
================
Comment at: source/Utility/UriParser.cpp:13
@@ -12,4 +12,3 @@
// C Includes
-#include <stdlib.h>
-#include <stdio.h>
+#include <string.h>
----------------
labath wrote:
> ovyalov wrote:
> > tberghammer wrote:
> > > I think you wanted to include <string>, not <string.h>
> > I need string.h for strlen - it's required even with <string> included .
> The C++ way would be to #include <cstring>
>
> </driveby>
Sorry, I missed that you use strlen
================
Comment at: source/Utility/UriParser.cpp:52-61
@@ +51,12 @@
+ // Extract hostname
+ if (host_port[0] == '[')
+ {
+ // hostname is enclosed with square brackets.
+ pos = host_port.find(']');
+ if (pos == std::string::npos)
+ return false;
+
+ tmp_hostname = host_port.substr(1, pos - 1);
+ host_port.erase(0, pos + 1);
+ }
+ else
----------------
ovyalov wrote:
> tberghammer wrote:
> > I would prefer no to remove the '[' and the ']' characters from the
> > hostname. At the moment you don't use the hostname for the adb protocol so
> > it isn't matter but if we consider IPv6 then having '[' and ']' around the
> > address sounds like a good idea to me (later stages can use this
> > information).
> Let me leave [] removal as-is since we treat hostname as device_id in case of
> adb and then use it for port forwarding setup -
> https://github.com/llvm-mirror/lldb/blob/master/source/Plugins/Platform/Android/PlatformAndroid.cpp#L199
I would prefer to remove them in PlatformAndroid when we convert it to devices
id, but if you want to leave it this way I am fine with that also.
http://reviews.llvm.org/D12025
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
