chaoren added inline comments.
================
Comment at: test/dosep.py:142
@@ -128,2 +141,3 @@
passes, failures = parse_test_results(output)
- update_status(name, command, output if exit_status != 0 else None)
+ if exit_status == 0:
+ report_test_pass(name, output[1])
----------------
zturner wrote:
> chaoren wrote:
> > Could you please do:
> >
> > ```
> > if exit_status != 0:
> > report_test_failure(...)
> > elif output_on_success:
> > report_test_pass(...)
> > ```
> >
> > so it's completely silent on success?
> I don't know that it should be completely silent. For starters, if you do it
> the way you suggest, it won't end up updating the progress, which is
> something you definitely need to see. But I think it's worthwhile to see the
> names of the individual tests that are running. The way I've written it now,
> you if `output_on_success` is False, you will only see one additional line,
> which is the name of the test being run. I think that's useful and does not
> add any noise to the output
Ah, I was thinking there would still be
```
\r x out of y test suites processed
```
my bad.
Could you change that to something like:
```
\r x out of y test suites processed - [test name]
```
with the carriage return (\r), so the screen doesn't scroll on success?
http://reviews.llvm.org/D11816
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
