> On May 17, 2019, at 5:03 AM, Ross Finlayson <finlay...@live555.com> wrote: > > > >> On May 17, 2019, at 12:43 AM, BONNISSENT Francois - Contractor >> <francois.bonniss...@external.thalesgroup.com> wrote: >> >> Hello >> I just integrated the mj2 format (MotionJepg2000) to the streaming live-media >> and in reception with openRTSP >> I used the latest version (2019.05.03) and submitted you a patch to apply to. > > Thank you. Can you point me at one or more examples of a “.mj2” file (i.e., > a motion-JPEG-2000 file) that I can use to test this?
Also, there’s a bug in your patch to “MediaSession.cpp” (for receiving RTP streams specified by a SDP description). You implement incoming “video/JPEG2000” streams using “SimpleRTPSource”, which seems wrong, because of the special (8-byte) RTP special header for JPEG 2000 (specified in RFC 5371, section 4.2). I notice that you define and implement a class “JPEG2000RTPSource” (BTW, for consistency with our other classes, this should really be named “JPEG2000VideoRTPSource” instead) - but you don’t use this anywhere. I presume that you meant to use this in “MediaSession.cpp”, instead of “SimpleRTPSource”? Also, the parameters for “JPEG2000RTPSource::createNew()” and “JPEG2000RTPSource::JPEG2000RTPSource()” are wrong. “mimeTypeString”, “offset”, and “doNormalMBitRule” should not be parameters, because those are actually constant properties of the JPEG 2000 RTP payload format. (I suggest that you use the “JPEGVideoRTPSource” class (specification and implementation) as a model here.) I can probably fix all of these things - but in any case, I can’t begin working on this unless/until I see one or more examples of a “.mj2” file (i.e., a motion-JPEG-2000 file) Ross Finlayson Live Networks, Inc. http://www.live555.com/ _______________________________________________ live-devel mailing list live-devel@lists.live555.com http://lists.live555.com/mailman/listinfo/live-devel
