On Wed Sep 30 14:41:29 2026 +0800, Hermes Wu wrote:
> it6625_read_edid() and it6625_write_edid() iterate their block loop
> with signed i/bank_ctrl locals holding only non-negative values; make
> them unsigned int and keep err signed. Reorder the declarations to put
> the pointer before the scalars while these functions are already being
> touched.
>
> Signed-off-by: Hermes Wu <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>
Patch committed.
Thanks,
Hans Verkuil
drivers/media/i2c/it6625.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/drivers/media/i2c/it6625.c b/drivers/media/i2c/it6625.c
index d98aa39f5ea1..4724c27bd8d0 100644
--- a/drivers/media/i2c/it6625.c
+++ b/drivers/media/i2c/it6625.c
@@ -663,8 +663,9 @@ static u64 it6625_get_pclk(struct it6625 *it6625)
static int it6625_read_edid(struct it6625 *it6625, u8 *edid, int start_block,
int num_blocks)
{
- int i, bank_ctrl, err = 0;
struct device *dev = it6625->dev;
+ unsigned int i, bank_ctrl;
+ int err = 0;
if (!edid) {
dev_err(dev, "edid buffer is NULL");
@@ -702,8 +703,9 @@ static int it6625_read_edid(struct it6625 *it6625, u8
*edid, int start_block,
static int it6625_write_edid(struct it6625 *it6625, u8 *edid, int start_block,
int num_blocks)
{
- int i, bank_ctrl, err = 0;
struct device *dev = it6625->dev;
+ unsigned int i, bank_ctrl;
+ int err = 0;
if (start_block < 0 || num_blocks <= 0 ||
start_block > EDID_NUM_BLOCKS_MAX ||
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
