On Tue Sep 15 15:45:30 2026 +0800, Guangshuo Li wrote:
> alvium_probe() increments the runtime PM usage count with
> pm_runtime_get_noresume() before enabling runtime PM. The probe error
> path correctly balances this reference with pm_runtime_put_noidle(),
> but the normal remove path only disables runtime PM.
>
> pm_runtime_disable() does not decrement the usage count, so a
> successful probe followed by driver removal leaves the runtime PM
> usage count unbalanced.
>
> Add the missing pm_runtime_put_noidle() to the remove path, matching
> the existing probe error cleanup.
>
> This issue was found by manual code inspection.
>
> Fixes: 0a7af872915e ("media: i2c: Add support for alvium camera")
> Cc: [email protected]
> Signed-off-by: Guangshuo Li <[email protected]>
> Signed-off-by: Sakari Ailus <[email protected]>
Patch committed.
Thanks,
Sakari Ailus
drivers/media/i2c/alvium-csi2.c | 1 +
1 file changed, 1 insertion(+)
---
diff --git a/drivers/media/i2c/alvium-csi2.c b/drivers/media/i2c/alvium-csi2.c
index f51f9b987759..f218999e0ed9 100644
--- a/drivers/media/i2c/alvium-csi2.c
+++ b/drivers/media/i2c/alvium-csi2.c
@@ -2523,6 +2523,7 @@ static void alvium_remove(struct i2c_client *client)
* make sure to turn power off manually.
*/
pm_runtime_disable(dev);
+ pm_runtime_put_noidle(dev);
if (!pm_runtime_status_suspended(dev))
alvium_set_power(alvium, false);
pm_runtime_set_suspended(dev);
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
