On Wed Jul 8 22:33:49 2026 +0800, Ruoyu Wang wrote:
> zoran_init_video_device() installs zoran_vdev_release() as the
> video_device release callback through zoran_template. After
> video_register_device() succeeds, video_unregister_device() drops the
> registered video_device reference and the V4L2 core eventually invokes
> that release callback, which kfree()s the video_device.
>
> zoran_exit_video_devices() called video_unregister_device() and then
> kfree(zr->video_dev), so device teardown could free the same
> video_device twice.
>
> Remove the direct kfree() and clear the cached pointer after
> unregistering. The pre-registration failure path keeps its manual free
> because the video_device was not registered there.
>
> This issue was found by a static analysis checker and confirmed by
> manual source review.
>
> Fixes: 82e3a496eb56 ("media: staging: media: zoran: move videodev alloc")
> Cc: [email protected]
> Signed-off-by: Ruoyu Wang <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>
Patch committed.
Thanks,
Hans Verkuil
drivers/media/pci/zoran/zoran_card.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/drivers/media/pci/zoran/zoran_card.c
b/drivers/media/pci/zoran/zoran_card.c
index 8bcf355a5418..e5ff407318df 100644
--- a/drivers/media/pci/zoran/zoran_card.c
+++ b/drivers/media/pci/zoran/zoran_card.c
@@ -886,7 +886,7 @@ static int zoran_init_video_device(struct zoran *zr, struct
video_device *video_
static void zoran_exit_video_devices(struct zoran *zr)
{
video_unregister_device(zr->video_dev);
- kfree(zr->video_dev);
+ zr->video_dev = NULL;
}
static int zoran_init_video_devices(struct zoran *zr)
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
