On Sun Jul 12 00:59:39 2026 +0100, Julian Braha wrote:
> Currently, VIDEO_AMD_ISP4_CAPTURE selects VIDEO_V4L2_SUBDEV_API without
> ensuring MEDIA_CONTROLLER is enabled, causing an unmet dependency:
>
> WARNING: unmet direct dependencies detected for VIDEO_V4L2_SUBDEV_API
> Depends on [n]: MEDIA_SUPPORT [=m] && VIDEO_DEV [=m] && MEDIA_CONTROLLER
> [=n]
> Selected by [m]:
> - VIDEO_AMD_ISP4_CAPTURE [=m] && MEDIA_SUPPORT [=m] &&
> MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && DRM_AMDGPU [=m]
> && DRM_AMD_ISP [=y] && HAS_DMA [=y] && VIDEO_DEV [=m]
>
> Many other options in this subsystem select MEDIA_CONTROLLER, let's do the
> same here.
>
> This unmet dependency bug was detected by kconfirm, a static analysis tool
> for Kconfig.
>
> Fixes: 9a54c285630c ("media: platform: amd: Introduce amd isp4 capture
> driver")
> Signed-off-by: Julian Braha <[email protected]>
> Reviewed-by: Bin Du <[email protected]>
> Signed-off-by: Sakari Ailus <[email protected]>
Patch committed.
Thanks,
Sakari Ailus
drivers/media/platform/amd/isp4/Kconfig | 1 +
1 file changed, 1 insertion(+)
---
diff --git a/drivers/media/platform/amd/isp4/Kconfig
b/drivers/media/platform/amd/isp4/Kconfig
index 9d1927af1cb8..77b61fae82ba 100644
--- a/drivers/media/platform/amd/isp4/Kconfig
+++ b/drivers/media/platform/amd/isp4/Kconfig
@@ -5,6 +5,7 @@ config VIDEO_AMD_ISP4_CAPTURE
depends on DRM_AMDGPU && DRM_AMD_ISP
depends on HAS_DMA
depends on VIDEO_DEV
+ select MEDIA_CONTROLLER
select VIDEOBUF2_CORE
select VIDEOBUF2_MEMOPS
select VIDEOBUF2_V4L2
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
