On Thu Mar 26 22:34:07 2026 +0100, Jose A. Perez de Azpillaga wrote:
> The nested loop inside the IS_ISP2401 block incorrectly uses the same
> variable 'i' as the outer loop. This shadows the outer loop variable
> and causes premature termination or skipped array elements.
>
> Change the inner loop to use a new variable 'j' to prevent this.
>
> Fixes: 113401c67386 ("media: atomisp: sh_css: Removed #ifdef ISP2401 to make
> code generic")
> Signed-off-by: Jose A. Perez de Azpillaga <[email protected]>
> Reviewed-by: Dan Carpenter <[email protected]>
> Signed-off-by: Sakari Ailus <[email protected]>
Patch committed.
Thanks,
Sakari Ailus
drivers/staging/media/atomisp/pci/sh_css.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/drivers/staging/media/atomisp/pci/sh_css.c
b/drivers/staging/media/atomisp/pci/sh_css.c
index f40b6912c14b..456c0b2df231 100644
--- a/drivers/staging/media/atomisp/pci/sh_css.c
+++ b/drivers/staging/media/atomisp/pci/sh_css.c
@@ -8190,7 +8190,7 @@ ERR:
int
ia_css_stream_destroy(struct ia_css_stream *stream)
{
- int i;
+ int i, j;
int err = 0;
IA_CSS_ENTER_PRIVATE("stream = %p", stream);
@@ -8221,10 +8221,10 @@ ia_css_stream_destroy(struct ia_css_stream *stream)
sp_pipeline_input_terminal =
&sh_css_sp_group.pipe_io[sp_thread_id].input;
- for (i = 0; i <
IA_CSS_STREAM_MAX_ISYS_STREAM_PER_CH; i++) {
+ for (j = 0; j <
IA_CSS_STREAM_MAX_ISYS_STREAM_PER_CH; j++) {
ia_css_isys_stream_h
isys_stream =
-
&sp_pipeline_input_terminal->context.virtual_input_system_stream[i];
- if
(stream->config.isys_config[i].valid && isys_stream->valid)
+
&sp_pipeline_input_terminal->context.virtual_input_system_stream[j];
+ if
(stream->config.isys_config[j].valid && isys_stream->valid)
ia_css_isys_stream_destroy(isys_stream);
}
}
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
