On Tue May 12 11:21:14 2026 +0800, Bin Du wrote:
> Newer Smatch snapshots no longer report the false positive around
> isp4if_send_fw_cmd(), so the extra list reinitialization before kfree()
> is no longer needed.
>
> Drop the stale list reinit and keep the cleanup path simpler.
>
> Signed-off-by: Bin Du <[email protected]>
> Signed-off-by: Sakari Ailus <[email protected]>
Patch committed.
Thanks,
Sakari Ailus
drivers/media/platform/amd/isp4/isp4_interface.c | 6 ------
1 file changed, 6 deletions(-)
---
diff --git a/drivers/media/platform/amd/isp4/isp4_interface.c
b/drivers/media/platform/amd/isp4/isp4_interface.c
index 15f14eddd683..8d73f66bb42c 100644
--- a/drivers/media/platform/amd/isp4/isp4_interface.c
+++ b/drivers/media/platform/amd/isp4/isp4_interface.c
@@ -459,12 +459,6 @@ put_ele_ref:
ele = NULL;
free_ele:
- /*
- * The response handler or the timeout/error path must dequeue the
- * command element before we own the final reference.
- */
- if (ele)
- INIT_LIST_HEAD(&ele->list);
kfree(ele);
return ret;
}
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
