On Fri May 15 11:12:06 2026 +0200, Arnd Bergmann wrote:
> With DRM_AMDGPU=m and DRM_AMD_ISP=y, it is possible to configura
> VIDEO_AMD_ISP4_CAPTURE as built-in, but that fails to link:
>
> aarch64-linux-ld: drivers/media/platform/amd/isp4/isp4_interface.o: in
> function `isp4if_gpu_mem_alloc.isra.0':
> isp4_interface.c:(.text+0x1d0): undefined reference to
> `isp_kernel_buffer_alloc'
> aarch64-linux-ld: drivers/media/platform/amd/isp4/isp4_interface.o: in
> function `isp4if_dealloc_fw_gpumem':
> isp4_interface.c:(.text+0x26c): undefined reference to
> `isp_kernel_buffer_free'
>
> Add a dependency on the tristate DRM_AMDGPU symbol in addition to
> the boolean DRM_AMD_ISP=y, so this can only be built-in if
> the ISP driver is also linked into the kernel itself.
>
> Fixes: 9a54c285630c ("media: platform: amd: Introduce amd isp4 capture
> driver")
> Signed-off-by: Arnd Bergmann <[email protected]>
> Reviewed-by: Bin Du <[email protected]>
> Tested-by: Bin Du <[email protected]>
> Signed-off-by: Sakari Ailus <[email protected]>
Patch committed.
Thanks,
Sakari Ailus
drivers/media/platform/amd/isp4/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/drivers/media/platform/amd/isp4/Kconfig
b/drivers/media/platform/amd/isp4/Kconfig
index 55dd2dc453a2..9d1927af1cb8 100644
--- a/drivers/media/platform/amd/isp4/Kconfig
+++ b/drivers/media/platform/amd/isp4/Kconfig
@@ -2,7 +2,9 @@
config VIDEO_AMD_ISP4_CAPTURE
tristate "AMD ISP4 and camera driver"
- depends on DRM_AMD_ISP && VIDEO_DEV && HAS_DMA
+ depends on DRM_AMDGPU && DRM_AMD_ISP
+ depends on HAS_DMA
+ depends on VIDEO_DEV
select VIDEOBUF2_CORE
select VIDEOBUF2_MEMOPS
select VIDEOBUF2_V4L2
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
