On Wed Nov 5 13:55:11 2025 +0800, Guoniu Zhou wrote:
> The field BLANK_PXL provides the value of the blank pixel to be inserted
> in the image in case an overflow error occurs in the output buffers of
> the channel. Its default value is 0xff, so no need to set again.
> 
> Besides, the field only exist in i.MX8QM/XP ISI version. Other versions
> like i.MX 8M series, remove the field since it won't send data to AXI bus
> when overflow error occurs and mark BLANK_PXL as reserved. i.MX9 series
> use it for other purposes.
> 
> Reviewed-by: Laurent Pinchart <[email protected]>
> Reviewed-by: Frank Li <[email protected]>
> Signed-off-by: Guoniu Zhou <[email protected]>
> Link: https://patch.msgid.link/[email protected]
> Signed-off-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

---

diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c 
b/drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c
index 9225a7ac1c3e..0187d4ab97e8 100644
--- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c
+++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c
@@ -309,8 +309,8 @@ static void mxc_isi_channel_set_control(struct mxc_isi_pipe 
*pipe,
 
        val = mxc_isi_read(pipe, CHNL_CTRL);
        val &= ~(CHNL_CTRL_CHNL_BYPASS | CHNL_CTRL_CHAIN_BUF_MASK |
-                CHNL_CTRL_BLANK_PXL_MASK | CHNL_CTRL_SRC_TYPE_MASK |
-                CHNL_CTRL_MIPI_VC_ID_MASK | CHNL_CTRL_SRC_INPUT_MASK);
+                CHNL_CTRL_SRC_TYPE_MASK | CHNL_CTRL_MIPI_VC_ID_MASK |
+                CHNL_CTRL_SRC_INPUT_MASK);
 
        /*
         * If no scaling or color space conversion is needed, bypass the
@@ -323,8 +323,6 @@ static void mxc_isi_channel_set_control(struct mxc_isi_pipe 
*pipe,
        if (pipe->chained)
                val |= CHNL_CTRL_CHAIN_BUF(CHNL_CTRL_CHAIN_BUF_2_CHAIN);
 
-       val |= CHNL_CTRL_BLANK_PXL(0xff);
-
        /* Input source (including VC configuration for CSI-2) */
        if (input == MXC_ISI_INPUT_MEM) {
                /*
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to