Dear Nicolas Dufresne:

Thanks for your patches! Unfortunately the Media CI robot detected some
issues:

# Test 
checkpatch:./0006-media-imx-jpeg-Add-encoder-ops-layer-for-hardware-ab.patch 
checkpatch
CHECK: Macro argument reuse 'jpeg' - possible side-effects?
#36: FILE: drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:67:
+#define call_void_jpeg_enc_ops(jpeg, op, args...)\
+do {\
+if ((jpeg)->enc_cfg_ops && (jpeg)->enc_cfg_ops->op)\
+(jpeg)->enc_cfg_ops->op(args);\
+} while (0)

CHECK: Macro argument reuse 'op' - possible side-effects?
#36: FILE: drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:67:
+#define call_void_jpeg_enc_ops(jpeg, op, args...)\
+do {\
+if ((jpeg)->enc_cfg_ops && (jpeg)->enc_cfg_ops->op)\
+(jpeg)->enc_cfg_ops->op(args);\
+} while (0)

CHECK: Macro argument 'op' may be better as '(op)' to avoid precedence issues
#36: FILE: drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:67:
+#define call_void_jpeg_enc_ops(jpeg, op, args...)\
+do {\
+if ((jpeg)->enc_cfg_ops && (jpeg)->enc_cfg_ops->op)\
+(jpeg)->enc_cfg_ops->op(args);\
+} while (0)

total: 0 errors, 0 warnings, 3 checks, 142 lines checked



Please fix your series, and upload a new version. If you have a patchwork
account, do not forget to mark the current series as Superseded.

For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/95780113/artifacts/report.htm
 .



Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.

---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html

If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
to this message.

_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to