On Sat Feb 7 22:05:44 2026 +0000, Artem Lytkin wrote:
> Replace BUG() with a return statement in the gpioirq tasklet handler.
> If saa7146_wait_for_debi_done() times out, crashing the kernel is
> disproportionate. The pr_err() already logs the failure, and returning
> early avoids accessing hardware in a potentially broken state.
>
> Signed-off-by: Artem Lytkin <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>
Patch committed.
Thanks,
Hans Verkuil
drivers/staging/media/av7110/av7110.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/drivers/staging/media/av7110/av7110.c
b/drivers/staging/media/av7110/av7110.c
index 607992100baf..014d0c6f0a8b 100644
--- a/drivers/staging/media/av7110/av7110.c
+++ b/drivers/staging/media/av7110/av7110.c
@@ -460,7 +460,7 @@ static void gpioirq(struct tasklet_struct *t)
if (saa7146_wait_for_debi_done(av7110->dev, 0)) {
pr_err("%s(): saa7146_wait_for_debi_done timed out\n",
__func__);
- BUG(); /* maybe we should try resetting the debi? */
+ return;
}
spin_lock(&av7110->debilock);
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
