Hi, The arch/ppc/syslib/gen550_dbg.c assumes UART registers are all accessed in bytes. However in some designs the bus connected to UART can only be addressed in 32 or 16 bits. So some flexibility is desirable. And the change is kinda trivial.
Before making this trivial change, I'm confused about two sets of defintions on io_type. In <linux/serial.h>, the following are defined. #define SERIAL_IO_PORT 0 #define SERIAL_IO_HUB6 1 #define SERIAL_IO_MEM 2 However in <linux/serial_core.h>, these are defined. #define UPIO_PORT (0) #define UPIO_HUB6 (1) #define UPIO_MEM (2) #define UPIO_MEM32 (3) Which set of defintion is better to be used in defining SERIAL_PORT_DFNS? Currently gen550_gdb.c use SERAIL_IO_XXXX macros. Either adding a new macro SERIAL_IO_MEM32 in <linux/serial.h> or just use what are already there. Are these two sets duplicated? If they are, maybe one of them will be deprecated soon. Regards, -Shawn.
