On Thu, 2006-04-06 at 09:06, Wade Farnsworth wrote: > On Thu, 2006-04-06 at 07:05, Vitaly Bordug wrote: > > > > Though I doubt if new boards are accepting to ppc/ currently, it's nice to > > have a patch > > available. BTW, I suggest to use phy abstraction and updated fs_enet > > (submitted here recently) <snip> > > > +CONFIG_USB_ARCH_HAS_HCD=y > > > +CONFIG_USB_ARCH_HAS_OHCI=y > > > > Not sure this is required as well. > > I'll disable this as well.
Looking at drivers/usb/Kconfig, these are actually enabled by default if CONFIG_PCI is enabled. CONFIG_USB then depends on CONFIG_USB_ARCH_HAS_HCD. > > <snip> > > > > +#ifdef CONFIG_PQ2FADS > > > +#define F2_RXCLK 13 > > > +#define F2_TXCLK 14 > > > +#else > > > #define F2_RXCLK 15 > > > #define F2_TXCLK 16 > > > +#endif > > > > > Hmm, this should go into the board-specific header - here should exist just > > a "reasonable default" (pq2ads.h in this context). > > > > > > > /* FCC3 Clock Source Configuration. These can be redefined in the board > > > specific file. > > > Can only choose from CLK13-16 */ > > > +#ifdef CONFIG_PQ2FADS > > > +#define F3_RXCLK 15 > > > +#define F3_TXCLK 16 > > > +#else > > > #define F3_RXCLK 13 > > > #define F3_TXCLK 14 > > > +#endif > > > > > ditto. > > Ok, I'll move these defines into pq2ads.h > Also, moving the defines into pq2ads.h results in some nasty warning messages. I'll put some #ifndef's around the #define's in pq2ads_pd.h to squelch them. -Wade
