Gerhard Sittig wrote:
>+ * Author is Alexander Popov<[email protected]>.
nit pick: is 1337 speak usual and appropriate here?
Um, that's his actual email address.
shouldn't headers get sorted alphabetically?
Is that a new policy? I've never heard that requirement.
+MODULE_AUTHOR("Alexander Popov <[email protected]>"); +MODULE_DESCRIPTION("MPC512x LocalPlus FIFO device driver"); +MODULE_LICENSE("GPL");aren't these usually at the end of the source for quick lookup?
Yes, and it should be "GPL v2" also. -- Timur Tabi _______________________________________________ Linuxppc-dev mailing list [email protected] https://lists.ozlabs.org/listinfo/linuxppc-dev
