On Wed, Jun 11, 2025 at 12:02:54PM +0200, Jiri Slaby (SUSE) wrote:
> uart_port::{serial_in,serial_out} (and plat_serial8250_port::* likewise)
> historically use:
> * 'unsigned int' for 32-bit register values in reads and writes, and
> * 'int' for offsets.
>
> Make them sane such that:
> * 'u32' is used for register values, and
> * 'unsigned int' is used for offsets.
>
> While at it, name hooks' parameters, so it is clear what is what.
At a glance this looks just mechanical change. Have you used coccinelle for
that?
As for the whole idea, I like it,
Reviewed-by: Andy Shevchenko <[email protected]>
> Signed-off-by: Jiri Slaby (SUSE) <[email protected]>
...
> Cc: Madhavan Srinivasan <[email protected]>
> Cc: Michael Ellerman <[email protected]>
> Cc: Nicholas Piggin <[email protected]>
> Cc: Christophe Leroy <[email protected]>
> Cc: "Ilpo Järvinen" <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> Cc: Paul Cercueil <[email protected]>
> Cc: Vladimir Zapolskiy <[email protected]>
> Cc: Kunihiko Hayashi <[email protected]>
> Cc: Masami Hiramatsu <[email protected]>
These also can be moved under '---' :-)
> ---
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
--
With Best Regards,
Andy Shevchenko
