Looks like my original patch https://sourceforge.net/p/dcplusplus/code/ci/bd419f3e1c1019a397129d37044dd9f7f679ffdb/ for cryptomanager was slightly incomplete in the end. Which is curious because I seem to recall deliberately testing the patch, as applied to dcpp, with an incorrect hub KEYP at some point before submitting said patch. I must have re-applied the changes from an incomplete patch file just prior to it being pushed.
If memory serves I separated my http manager and keyp changes to two separate patches from a single working copy, there was a similar incorrect application of changes related to httpmanager changes that was addressed some time later. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1516181 Title: disabled keyprint check for hubs Status in DC++: New Bug description: according to this line http://sourceforge.net/p/dcplusplus/code/ci/default/tree/dcpp/Client.cpp#l143, keyprint of hub will never sended to SSLSocket, so CryptoManager::verify_callback will fail to check certificate's keyprint and will return ok even if allowUntrustedHubs is off. This line should ends with SETTING(ALLOW_UNTRUSTED_HUBS), true, keyprint); To manage notifications about this bug go to: https://bugs.launchpad.net/dcplusplus/+bug/1516181/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~linuxdcpp-team Post to : linuxdcpp-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~linuxdcpp-team More help : https://help.launchpad.net/ListHelp