hey,
sorry for the late reply.

this is looking very good! i have minor points but nothing blocking,
hopefully:

1) could you test 2 downloads in parallel and confirm nothing gets mixed
up?

2) are plugins able to determine whether a download has succeeded or
failed in their "done" notification?

3) the 2 getDataArrayPtr functions are nearly identical - maybe have one
call the other?

4) the "HTTP file" term just jumped to me, especially now that we don't
necessarily download to (or from) files. i think a better term is
"resource" <https://en.wikipedia.org/wiki/Web_resource>.

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1451223

Title:
  Support for HTTP file retrieval in DC Plugin

Status in DC++:
  Fix Committed

Bug description:
  It should be possible to download a file through HTTP with a DC
  Plugin.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1451223/+subscriptions

_______________________________________________
Mailing list: https://launchpad.net/~linuxdcpp-team
Post to     : linuxdcpp-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~linuxdcpp-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to