How could this be a failed download (as like in your solution)? Stopping the download when it could continue seems equally confusing. There's two solution here for a rare problem that is expected to go away soon (on Windows), at least at the next restart of the client so things go back to the normal way after.
Both solutions accomplish the goal to stop spamming but in a different way. Mines is simple and also allow to download smaller files while the problem's still existing. When the client is restarted the bad flag goes away since it's not saved in the queue so if there's no hashdata file lock anymore then things can continue in their normal way. Completly stopping the download (yours) is another solution but I looked at your implementation and there's a big difference between DC++ and your code in this area (exception handling in HashManager, the ConnectionManager call) so if you'd like to push your method then please create a patch for DC++. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1194085 Title: Infinite download loop for a single tree Status in DC++: Confirmed Bug description: It goes as follows: 1. DC++ tries to save a downloaded tree in hash data but the data file isn't writable. 2. The client searches for other downloads from the same user and finds the same file again. 3. The client can't find the tree for that file and downloads it again (back to step 1.) While the problem happens relatively rarely on Windows, it's much more common with Linux clients. Even though there's a log message when the writing fails, it seems that users don't generally notice it, which is why some users have even requested a feature for banning IP addresses from the client (and I've also seen users downloading the same tree from me for several hours). I've fixed this issue in AirDC++ 2.50 by catching the database exceptions in DownloadManager::endData, forwarding the error to the connecting item and changing the item to a state where it will connect only when the user manually forces the connection. To manage notifications about this bug go to: https://bugs.launchpad.net/dcplusplus/+bug/1194085/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~linuxdcpp-team Post to : linuxdcpp-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~linuxdcpp-team More help : https://help.launchpad.net/ListHelp
