For (1) I chose this to have the simplest data type to store the extension data in, if its more optimal to store them in a larger and more sophisticated object I can change it.
For (2) I put it to search manager because these data belong to searches and it is the used model in eg. ShareManager or WindowManager with their own data. However, putting it to SettingsManager sounds more reasonable not to say that a bug I found when the settings file does not extist yet is easier to fix this way. (3) I also thought that some warning would be nice to show when a custom search type selected and there are any NMDC hubs online. My ideas were put a warning message to the statusbar or add '(ADC only)' to the custom defined names in the dropdown elements. Any better idea? (Btw. in the settings pane there is a warning that the types configured here have affect on ADC searches only) Users cannot modify/delete the name of predefined types (only the extension list). This can be allowed later when NMDC support is dropped. I don't understand the last question. Extension list for both of predefined and custom searches can be changed between searches. The only thing can be done is to skip querying the ADC extension list when there aren't any onine ADC hubs. Also the predefined extensions in the patch are for testing only, I'd like to see proposals for default extensions for the 5 predefined groups. I think there should be no more than 15-20 extension per type. -- Request for more filtering options on search https://bugs.launchpad.net/bugs/326541 You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. Status in DC++: New Bug description: It would be a really handy feature to define own "filetype" filters. For example we do have a file tye "archive" that would give you only zip, rar, ace and lzh-Files. It would be really cool to add mx own types like for comics: cbr, cbz, cba, ace, zip, rar, lzh and folders. So that I don't have to scroll trough endless lists of mp3 . . . As far as i have been told is that an idea that would require changes in the protocol or the hub software, so I suggest an additional local filter: Search for all files on the hub, but show only . . . Thanx for a great software! mabuse _______________________________________________ Mailing list: https://launchpad.net/~linuxdcpp-team Post to : linuxdcpp-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~linuxdcpp-team More help : https://help.launchpad.net/ListHelp
