From: Steven Rostedt <[email protected]> The function tracing_alloc_snapshot() is only used between trace.c and trace_snapshot.c. When snapshot isn't configured, it's not used at all. The stub function was defined as a global with no users and no prototype causing build issues.
Remove the function when snapshot isn't configured as nothing is calling it. Also remove the EXPORT_SYMBOL_GPL() that was associated with it as it's not used outside of the tracing subsystem which also includes any modules. Reported-by: Mark Brown <[email protected]> Closes: https://lore.kernel.org/all/[email protected]/ Fixes: bade44fe546212 (tracing: Move snapshot code out of trace.c and into trace_snapshot.c) Signed-off-by: Steven Rostedt (Google) <[email protected]> --- kernel/trace/trace.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index ec2b926436a7..7f2fbf9c36df 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -810,19 +810,12 @@ int tracing_alloc_snapshot(void) return ret; } -EXPORT_SYMBOL_GPL(tracing_alloc_snapshot); #else void tracing_snapshot(void) { WARN_ONCE(1, "Snapshot feature not enabled, but internal snapshot used"); } EXPORT_SYMBOL_GPL(tracing_snapshot); -int tracing_alloc_snapshot(void) -{ - WARN_ONCE(1, "Snapshot feature not enabled, but snapshot allocation used"); - return -ENODEV; -} -EXPORT_SYMBOL_GPL(tracing_alloc_snapshot); void tracing_snapshot_alloc(void) { /* Give warning */ -- 2.51.0
