Hi Oli, thanks for your contribution. Some comments below:
On Tue, Mar 10, 2026 at 10:01:41PM -0500, Oli wrote: > From c78a0572f5ec2b927f9b723af687e6ef913561a4 Mon Sep 17 00:00:00 2001 > From: Eddie Hudgins <[email protected]> > Date: Tue, 10 Mar 2026 21:53:07 -0500 > Subject: [PATCH] Signed-off-by: Eddie Hudgins <[email protected]> > arch/x86/tools: Removed headers in relocs_32.c scripts/basic: Removed > headers > in fixdep.c drivers/pps: Removed headers in pps.c drivers/input: Removed > headers in input-mt.c Usually, patch mails do not contain mail headers within their body; the only possible exception is 'From:' if the sender is not the patch author. These additional headers prevent the usual patch application (e.g. 'git am <mail'). > > These changes compile for x86, x86_64, and powerpc (Those were the only > ones fairly tested) under defconfig. This aims to clean up code and > simplify the files for developers. This will also contribute to start of > decluttering the environment. A commit subject should start with a subsystem identifier. A commit message should tell about the what and why of the patch, followed by a 'Signed-of-by'. E.g.: kbuild: fixdep: Remove unused includes Remove unused #include statements for clean up. Signed-off-by: Your Name <[email protected]> (More complex changes require more details commit message). Please check Documentation/process/submitting-patches.rst. [...] > diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c > index cdd5da7e009b..feb9e7d8984d 100644 > --- a/scripts/basic/fixdep.c > +++ b/scripts/basic/fixdep.c > @@ -89,7 +89,6 @@ > * but I don't think the added complexity is worth it) > */ > > -#include <sys/types.h> > #include <sys/stat.h> > #include <unistd.h> > #include <fcntl.h> > -- > 2.43.0 The change in scripts/basic/fixdep.c looks good to me. Do you want to prepare a new kbuild-only patch and want me to take it for kbuild? Kind regards, Nicolas
