On Mon, Feb 17, 2025 at 12:57:07PM +0100, Rafael J. Wysocki wrote: > +Ulf > > On Mon, Feb 10, 2025 at 6:58 AM Keita Morisaki <[email protected]> wrote: > > > > The trace event cpu_idle provides insufficient information for debugging > > PSCI requests due to lacking access to determined PSCI domain idle > > states. The cpu_idle usually only shows -1, 0, or 1 regardless how many > > idle states the power domain has. > > > > Add new trace events namely psci_domain_idle_enter and > > psci_domain_idle_exit to trace enter and exit events with a determined > > idle state. > > > > These new trace events will help developers debug CPUidle issues on ARM > > systems using PSCI by providing more detailed information about the > > requested idle states. > > > > Signed-off-by: Keita Morisaki <[email protected]> > > Reviewed-by: Steven Rostedt (Google) <[email protected]> > > Reviewed-by: Dhruva Gole <[email protected]> > > Tested-by: Kevin Hilman <[email protected]> > > --- > > v1->v2: Split the ftrace event into two (psci_domain_idle_(enter|exit)) > > and rephrase the commit message accordingly. Rebased onto the > > latest. > > v2->v3: Add "Reviewed-by: Steven Rostedt" > > v3->v4: Add the Tested-by label > > v4->v5: Add "Reviewed-by: Dhruva Gole" > > > > Hopefully this patch gets attention from maintainers of > > drivers/cpuidle/cpuidle-psci.c too. > > Lorenzo, Sudeep, Ulf, any comments? >
Looks good to me. I left it to Ulf, FWIW: Acked-by: Sudeep Holla <[email protected]> -- Regards, Sudeep
