As reported by Andrii we don't currently recognize uretprobe.multi.s
programs as return probes due to using (wrong) strcmp function.

Using str_has_pfx() instead to match uretprobe.multi prefix.

Tests are passing, because the return program was executed
as entry program and all counts were incremented properly.

Reported-by: Andrii Nakryiko <[email protected]>
Signed-off-by: Jiri Olsa <[email protected]>
Signed-off-by: Andrii Nakryiko <[email protected]>
Link: https://lore.kernel.org/bpf/[email protected]
---
 tools/lib/bpf/libbpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 274441674f92..6917d4a0bd4e 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -11684,7 +11684,7 @@ static int attach_uprobe_multi(const struct bpf_program 
*prog, long cookie, stru
                ret = 0;
                break;
        case 3:
-               opts.retprobe = strcmp(probe_type, "uretprobe.multi") == 0;
+               opts.retprobe = str_has_pfx(probe_type, "uretprobe.multi");
                *link = bpf_program__attach_uprobe_multi(prog, -1, binary_path, 
func_name, &opts);
                ret = libbpf_get_error(*link);
                break;
-- 
2.46.0


Reply via email to