On Mon, Sep 28, 2020 at 12:37 PM Chen-Yu Tsai <[email protected]> wrote: > > On Mon, Sep 28, 2020 at 3:29 AM Clément Péron <[email protected]> wrote: > > > > We are actually using a complex formula to just return a bunch of > > simple values. Also this formula is wrong for sun4i when calling
BTW, it is entirely possible that the compiler optimizes your switch-case back into the original complex formula you replaced. :) > > get_wss() the function return 4 instead of 3. > > > > Replace this with a simpler switch case. > > > > Also drop the i2s params which is unused and return a simple int as > > returning an error code could be out of range for an s8 and there is > > no optim to return a s8 here. > > > > Signed-off-by: Clément Péron <[email protected]> > > Fixes: 619c15f7fac9 ("ASoC: sun4i-i2s: Change SR and WSS computation") > > Reviewed-by: Chen-Yu Tsai <[email protected]> -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/CAGb2v65c2NzjxN4FSksvzQKOvZz0e9ccsKT9OuLpmUVr_WNtzQ%40mail.gmail.com.
