Setting up the clocks properly is quite critical to the system's operation, but currently our error handling is not very verbose. This series adds error handling and reporting to the sunxi clocks, so that any errors are correctly detected and reported. Also previous actions are rolled back in case something went wrong. This proves to be helpful in debugging clock tree issues, especially when adding support for new SoCs. I tested this on a BananaPi by deliberately misspelling "clock-output-names". The resulting kernel crash in sun4i_timer_interrupt is totally misleading, but now there is a line in the dmesg before saying: ======= sunxi_divider_clk_setup: could not read clock-output-names for "apb0" =======
This applies on top of Maxime's sunxi/for-next branch. Changes v1 .. v2: - in all three patches: - use of_clock_full_name() instead of node->name - don't report the uninitialized clk_name - handle error in final check in if-clause Andre Przywara (3): clk: sunxi: improve mux_clk error handling and reporting clk: sunxi: improve divider_clk error handling and reporting clk: sunxi: Improve divs_clk error handling and reporting drivers/clk/sunxi/clk-sunxi.c | 75 ++++++++++++++++++++++++++++++++++++------- 1 file changed, 63 insertions(+), 12 deletions(-) -- 2.6.4 -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
