Hi, On Tue, Dec 29, 2015 at 11:17:16PM +0100, Marcus Weseloh wrote: > Hi, > > while doing more debugging and examining the output from the SPI controller > on an oscilloscope, I noticed another problem in the spi-sun4i driver. Now I'm > really unsure how to deal with these fixes with regard to the word wait time > patch series... Should I fold them into the existing series, or should I > create a new one only for the fixes? > > And if folding in is the way to go, do I send the whole series to all relevant > recipients of all patches, or should each patch be sent only to the recipients > relevant for each separate patch? > > I'm sorry, I know this is all very noisy. I'm new to this and am still > learning the ropes... > > Cheers, > > Marcus > > --- > The SPI core calls set_cs before a transfer, but the SUN4I_CTL_CS_MANUAL > flag is only set in transfer one. This leads to the following pattern on > the chip-select line (with runtime power-management on every transfer, > without it only on the first one): > > activate, deactivate, activate, transfer, deactivate > > Moving the configuration of the SUN4I_CTL_CS_MANUAL flag from transfer_one > to set_cs removes this problem. > > Signed-off-by: Marcus Weseloh <[email protected]>
It looks sane, but you didn't Cc the appropriate mailing lists. Git also drops everything after '---', which means that your commit log will be droped, while the introduction will actually become your commit log, which is probably not what you mean. Please resend it to the right recipients, and you can send it with my Acked-by: Maxime Ripard <[email protected]> Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: Digital signature
