This patch has not been sent to the proper mailing lists....

On Sun, May 03, 2015 at 08:43:04PM +0100, Michal Suchanek wrote:
> Log messages about claimed sram.

... lacks a meaningful commit log ...

> 
> Signed-off-by: Michal Suchanek <[email protected]>
> ---
>  drivers/soc/sunxi/sunxi_sram.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c
> index 5b76fd1..f2bce8e 100644
> --- a/drivers/soc/sunxi/sunxi_sram.c
> +++ b/drivers/soc/sunxi/sunxi_sram.c
> @@ -35,6 +35,8 @@ struct sunxi_sram_desc {
>       bool                    enabled;
>  };
>  
> +static struct device *dev;
> +
>  #define SUNXI_SRAM_MAP(_val, _func)                          \
>       {                                                       \
>               .func = _func,                                  \
> @@ -127,11 +129,13 @@ int sunxi_sram_claim(enum sunxi_sram_type type, const 
> char *function)
>  
>               if (sram->claimed) {
>                       spin_unlock(&sram_lock);
> +                     dev_warn(dev, "Sram %s already claimed.\n", sram->name 
> );

... and has some checkpatch errors.

You should seriously consider reading Documentation/SubmittingPatches.

(and I think it could even be logged as an error.)

>                       return -EBUSY;
>               }
>  
>               sram->claimed = true;
>               spin_unlock(&sram_lock);
> +             dev_dbg(dev, "Claiming sram %s for %s.\n", sram->name, function 
> );
>  
>               for (func = sram->func; func->func; func++) {
>                       if (strcmp(function, func->func))
> @@ -164,6 +168,7 @@ int sunxi_sram_release(enum sunxi_sram_type type)
>               spin_lock(&sram_lock);
>               sram->claimed = false;
>               spin_unlock(&sram_lock);
> +             dev_dbg(dev, "Releasing sram %s.\n", sram->name );

SRAM is an acronym, it should be written uppercase.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Attachment: signature.asc
Description: Digital signature

Reply via email to