Hi,
On 02-01-15 09:53, Daniel Kochmański wrote:
This is a series of patches to enable nand read functionality on sunxi
devices. It uses DMA and is able to read from syndrome partitions and
normal ones. Additionaly mksunxiboot tool is patched to be able to
format resulting binary to be able to read from BROM, so NAND SPL builds
are now possible. a20_nandread command is added for conveniance.
Afaik DMA controller doesn't vary between a10 and a20, so this should
work on a10 devices, but due to no a10 hardware it wasn't tested.
First of all many thanks for working on this!
I see that this is against linux-sunxi/u-boot-sunxi.git, that is not
(really) being actively developed anymore, see:
https://www.marshut.net/kuispp/linux-sunxi-u-boot-sunxi-is-no-longer-supported-time-to-switch-to-upstream-u-boot.html
Can you please rebase on top of upstream u-boot, on top of the next
branch:
http://git.denx.de/?p=u-boot/u-boot-sunxi.git;a=shortlog;h=refs/heads/next ?
Your patches all seem to only have a subject and not a proper commit message,
please add a commit message to all of them describing the changes in somewhat
more detail then you do in the subject, you could e.g. re-use bits of your
coverletter. Also for upstream u-boot we require a Signed-off-by as part of the
commit message, so please add a line like this one to all your commit messages:
Signed-off-by: Daniel Kochmański <[email protected]>
You can make git do this automatically by specifying the -s option when
committing,
also please send further versions of this patch-set to the upstream u-boot
list.
Besides all the above, which is easily fixed, unfortunately we also have the
problem
(or luxury) that Yassin Jaffer (added to the CC) has also been working on nand
support,
re-using the upstream kernel code Boris Brezillon has been working on, see:
https://github.com/yassinjaffer/u-boot/commits/sunxi-nand
I believe that Yassin's version is better then yours because it re-uses existing
nand infrastructure rather then more or less starting from scratch.
But Yassin has not been very active on this, and has been reluctant to submit
his work upstream because it has not been tested a lot yet.
The best way forward may very well be you picking up Yassin's work (in
coordination
with Yassin), and submitting that to upstream u-boot.
Yassin, I notice that the patches in your git repo do not have a Signed-off-by,
can you please reply to this mail with your Signed-off-by to indicate that it is
ok for us to add your Signed-off-by to your patches ?
Regards,
Hans
Daniel Kochmański (4):
sunxi: nand: add minimal nand driver (reading flash only).
sunxi: mksunxiboot: increase block size, so checksum is correct on
nand
sunxi: nand: add nand spl boot option
sunxi: nand: add a20_nandread command
arch/arm/cpu/armv7/sunxi/board.c | 4 +
board/sunxi/Makefile | 1 +
board/sunxi/nand.c | 252 +++++++++++++++++++++++++++++++++++++++
common/Makefile | 1 +
common/cmd_a20_nandread.c | 26 ++++
common/spl/spl_nand.c | 23 +++-
include/configs/sunxi-common.h | 25 ++--
tools/mksunxiboot.c | 2 +-
8 files changed, 322 insertions(+), 12 deletions(-)
create mode 100644 board/sunxi/nand.c
create mode 100644 common/cmd_a20_nandread.c
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
