Hi,

On 10/08/2014 07:11 PM, Paul Kocialkowski wrote:
> Signed-off-by: Paul Kocialkowski <[email protected]>
> ---
>  drivers/input/keyboard/sun4i-keyboard.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/keyboard/sun4i-keyboard.c 
> b/drivers/input/keyboard/sun4i-keyboard.c
> index 74869e1..fa3bd45 100644
> --- a/drivers/input/keyboard/sun4i-keyboard.c
> +++ b/drivers/input/keyboard/sun4i-keyboard.c
> @@ -194,7 +194,7 @@ static void sun4i_keyboard_resume(struct early_suspend *h)
>       printk("enter laterresume: sun4i_keyboard_resume. \n");
>  #endif
>  
> -     
> writel(FIRST_CONCERT_DLY|LEVELB_VOL|KEY_MODE_SELECT|LRADC_HOLD_EN|ADC_CHAN_SELECT|LRADC_SAMPLE_62HZ|LRADC_EN,KEY_BASSADDRESS
>  + LRADC_CTRL);
> +     
> writel(FIRST_CONCERT_DLY|LEVELB_VOL|KEY_MODE_SELECT|LRADC_HOLD_EN|ADC_CHAN_SELECT|LRADC_SAMPLE_250HZ|LRADC_EN,KEY_BASSADDRESS
>  + LRADC_CTRL);
>       return ;
>  }
>  #else

Hmm, all the debounce times are in samplerate times to, so this seriously 
shortens the
debounce time, which is not a good idea IMHO, this will make the debounce so 
short, that
we are likely to see false keypresses from bounces.

Regards,

Hans

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to