> > > +static struct mfd_cell axp20x_cells[] = {
> > > + {
> > > + .name = "axp20x-pek",
> > > + .num_resources = ARRAY_SIZE(axp20x_pek_resources),
> > > + .resources = axp20x_pek_resources,
> > > + }, {
> > > + .name = "axp20x-regulator",
> > > + },
> > > +};
> >
> > nit: The format of these two structs are inconsistent.
>
> Uhm, what do you mean?
Well you've removed the struct above this one in your reply. Take a
look at my reply to you and see the differences between this _two_
structs, this being only one of them.
[...]
> > > +static const struct i2c_device_id axp20x_i2c_id[] = {
> > > + { "axp202", AXP202_ID },
> > > + { "axp209", AXP209_ID },
> > > + { }
> > > +};
> > > +MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
> >
> > Isn't this redundant now that you're using of_id?
>
> It is not. Even it is unused it has to be in the driver otherwise the
> driver is not loaded. Probably it is something wrong in the I2C core.
Sorry, I should have been more specific. The I2C core requires this
struct, but the IDs are unused and redundant. Best remove them in
order to mitigate any confusion.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
