Hi Vineet,
FYI, a second version of the patch is submitted [1]. Regarding what
has changed, a changelog is put right after the sign-off line.
On 11/19/22 01:34, Vineet Gupta wrote:
> On 11/18/22 05:15, Shahab Vahedi wrote:
>> The majority of the update is about adding new definitions,
>> specially for the relocations. However, there is one rename, one
>> deletion, and one change:
>
> For completeness: And some cosmetic changes to uppercase hex digits.
Indeed, there are some cosmetic changes. If you don't mind, I'm going
to leave this part out of the commit message.
>> -#define R_ARC_JUMP_SLOT 0x37
>> +#define R_ARC_JMP_SLOT 0x37
>
> Did you build glibc with this change ? There are references to old definition.
>
> git grep R_ARC_JUMP_SLOT
>
> sysdeps/arc/dl-machine.h:199: ((((type) == R_ARC_JUMP_SLOT
> \
> sysdeps/arc/dl-machine.h:206:#define ELF_MACHINE_JMP_SLOT R_ARC_JUMP_SLOT
> sysdeps/arc/dl-machine.h:277: case R_ARC_JUMP_SLOT:
> sysdeps/arc/dl-machine.h:337: if (r_type == R_ARC_JUMP_SLOT)
Thank you very much for noticing this. This was a snafu on my part.
I forgot to bring the complete changes from an old downstream branch
I had. This has been fixed in v2 of the patch [1] which is now tested
by building the current master branch:
$ module load <arcv2_toolchain>
$ configure --prefix=/usr \
--with-headers=/path/to/sysroot/usr/include \
--build=x86_64-pc-linux-gnu \
--host=arc-snps-linux-gnu \
--target=arc-snps-linux-gnu \
--disable-werror \
CFLAGS="-Og -g3 -fvar-tracking-assignments" \
CXXFLAGS="-Og -g3 -fvar-tracking-assignments"
$ make
[1]
https://sourceware.org/pipermail/libc-alpha/2022-November/143536.html
--
Shahab
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
