On Mon, 2019-04-01 at 11:08 -0700, Vineet Gupta wrote:
> On 4/1/19 11:04 AM, Eugeniy Paltsev wrote:
> > > +         if (IS_ENABLED(CONFIG_HIGHMEM) || is_pae40_enabled())
> > 
> > As for today PAE40 couldn't be enabled without HIGHMEM for ARC, so probably 
> > we can
> > simplify this to
> > 
> > ----------------------------->8----------------------------------
> > if (IS_ENABLED(CONFIG_HIGHMEM))
> >     ioc_enable = 0;
> 
> That is true, but mentioning both sort of documents the requirements.
> Also these checks are compile time only so don't add any extra code 
> whatsoever.

OK, I'm fine with it. Let's check both conditions explicitly.

> -Vineet
> 
-- 
 Eugeniy Paltsev
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Reply via email to