Hi Vineet, On Tue, 2016-02-02 at 19:59 +0530, Vineet Gupta wrote: > Hi Alexey, > > On Tuesday 02 February 2016 06:45 PM, Alexey Brodkin wrote: > > Hi Vineet, > > > > On Tue, 2016-02-02 at 16:28 +0530, Vineet Gupta wrote: > > > + > > > +Required properties: > > > + > > > +- compatible : should be "snps,arc-timer0" > > > +- interrupts : single Interrupt going into parent intc > > > + (16 for ARCHS cores, 3 for ARC700 cores) > > > +- clocks : phandle to the source clock > > > > Actually we're not flexible here. > > See we have hard-coded "core_clk" in [PATCH 8/9]. > > We use it directly in show_cpuinfo() for reading clock speed > > as well as in axs103_early_init(). > > > > So "source clock" here MUST be "core_clk", otherwise > > /proc/cpuinfo will report junk instead of meaningful data at least. > > Using hardcoded DT names in generic code is total BS and I slap myself for > missing > that in reviewing 8/9. Please fix it !
But the only other alternative to hard-coded name is use of some internal variable like "arc_timer_freq". I.e. we make "arc_timer_freq" global and use it for displaying core frequency. Are you OK with that? -Alexey _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
